source: branches/chaos_calmer/package/kernel/mac80211/patches/351-0042-brcmfmac-initialize-variable-in-brcmf_sdiod_regrl.patch @ 49407

Last change on this file since 49407 was 49407, checked in by rmilecki, 12 months ago

mac80211: brcmfmac: backport changes from 2016-09-27

This fixes memory leaks, some possible crashes and bug that could cause
WARNING on every add_key/del_key call. It also replaces WARNING with
a simple message. They may still occur e.g. on station going out of
range and A-MPDU stall in the firmware.

Signed-off-by: Rafał Miłecki <rafal@…>

File size: 1.1 KB
  • drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c

    From 26305d3d7298d1ddf8fd4ce95a382aa90534f0a3 Mon Sep 17 00:00:00 2001
    From: Arend Van Spriel <arend.vanspriel@broadcom.com>
    Date: Mon, 19 Sep 2016 12:09:54 +0100
    Subject: [PATCH] brcmfmac: initialize variable in brcmf_sdiod_regrl()
    
    In case of an error the variable returned is uninitialized. The caller
    will probably check the error code before using it, but better assure
    it is set to zero.
    
    Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
    Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
    Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    ---
     drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    a b u8 brcmf_sdiod_regrb(struct brcmf_sdio_d 
    416416 
    417417u32 brcmf_sdiod_regrl(struct brcmf_sdio_dev *sdiodev, u32 addr, int *ret) 
    418418{ 
    419         u32 data; 
     419        u32 data = 0; 
    420420        int retval; 
    421421 
    422422        brcmf_dbg(SDIO, "addr:0x%08x\n", addr); 
Note: See TracBrowser for help on using the repository browser.