source: branches/chaos_calmer/package/kernel/mac80211/patches/351-0044-brcmfmac-remove-unnecessary-null-pointer-check.patch @ 49407

Last change on this file since 49407 was 49407, checked in by rmilecki, 12 months ago

mac80211: brcmfmac: backport changes from 2016-09-27

This fixes memory leaks, some possible crashes and bug that could cause
WARNING on every add_key/del_key call. It also replaces WARNING with
a simple message. They may still occur e.g. on station going out of
range and A-MPDU stall in the firmware.

Signed-off-by: Rafał Miłecki <rafal@…>

File size: 1.2 KB
  • drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c

    From 835680b82f029818c813324aed3073cdcf63241f Mon Sep 17 00:00:00 2001
    From: Hante Meuleman <hante.meuleman@broadcom.com>
    Date: Mon, 19 Sep 2016 12:09:56 +0100
    Subject: [PATCH] brcmfmac: remove unnecessary null pointer check
    
    in the function brcmf_bus_start() in the exception handling a
    check is made to dermine whether ifp is null, though this is not
    possible. Removing the unnessary check.
    
    Reviewed-by: Arend Van Spriel <arend.vanspriel@broadcom.com>
    Reviewed-by: Franky Lin <franky.lin@broadcom.com>
    Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
    Signed-off-by: Hante Meuleman <hante.meuleman@broadcom.com>
    Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    ---
     drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 3 +--
     1 file changed, 1 insertion(+), 2 deletions(-)
    
    a b fail: 
    10481048                brcmf_fws_del_interface(ifp); 
    10491049                brcmf_fws_deinit(drvr); 
    10501050        } 
    1051         if (ifp) 
    1052                 brcmf_net_detach(ifp->ndev, false); 
     1051        brcmf_net_detach(ifp->ndev, false); 
    10531052        if (p2p_ifp) 
    10541053                brcmf_net_detach(p2p_ifp->ndev, false); 
    10551054        drvr->iflist[0] = NULL; 
Note: See TracBrowser for help on using the repository browser.