source: branches/chaos_calmer/package/kernel/mac80211/patches/351-0050-brcmfmac-replace-WARNING-on-timeout-with-a-simple-er.patch @ 49407

Last change on this file since 49407 was 49407, checked in by rmilecki, 12 months ago

mac80211: brcmfmac: backport changes from 2016-09-27

This fixes memory leaks, some possible crashes and bug that could cause
WARNING on every add_key/del_key call. It also replaces WARNING with
a simple message. They may still occur e.g. on station going out of
range and A-MPDU stall in the firmware.

Signed-off-by: Rafał Miłecki <rafal@…>

File size: 1.5 KB
  • drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c

    From 2f0e56fa37cce60a5ac5d451bcadec51cd711436 Mon Sep 17 00:00:00 2001
    From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
    Date: Tue, 27 Sep 2016 12:12:24 +0200
    Subject: [PATCH] brcmfmac: replace WARNING on timeout with a simple error
     message
    MIME-Version: 1.0
    Content-Type: text/plain; charset=UTF-8
    Content-Transfer-Encoding: 8bit
    
    Even with timeout increased to 950 ms we get WARNINGs from time to time.
    It mostly happens on A-MPDU stalls (e.g. when station goes out of
    range). It may take up to 5-10 secods for the firmware to recover and
    for that time it doesn't process packets.
    
    It's still useful to have a message on time out as it may indicate some
    firmware problem and incorrect key update. Raising a WARNING however
    wasn't really that necessary, it doesn't point to any driver bug anymore
    and backtrace wasn't much useful.
    
    Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
    Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
    Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
    ---
     drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 3 ++-
     1 file changed, 2 insertions(+), 1 deletion(-)
    
    a b int brcmf_netdev_wait_pend8021x(struct b 
    11551155                                 !brcmf_get_pend_8021x_cnt(ifp), 
    11561156                                 MAX_WAIT_FOR_8021X_TX); 
    11571157 
    1158         WARN_ON(!err); 
     1158        if (!err) 
     1159                brcmf_err("Timed out waiting for no pending 802.1x packets\n"); 
    11591160 
    11601161        return !err; 
    11611162} 
Note: See TracBrowser for help on using the repository browser.