bogus Reset switch press on WRT54GS V1 @ kamikaze causes stuckness in /etc/preinit
|Reported by:||anonymous||Owned by:||mbm|
|Priority:||high||Milestone:||Barrier Breaker 14.07|
|Keywords:||failsafe reset switch||Cc:|
When trying kamikaze 5684 with the patch from #983 (I haven't looked at it without),
my WRT54GS falsely detects a reset button press during boot.
I have tried the following patch just to make sure I'm not kidding me:
Index: trunk/package/broadcom-diag/src/diag.c =================================================================== --- trunk/package/broadcom-diag/src/diag.c (revision 5684) +++ trunk/package/broadcom-diag/src/diag.c (working copy) @@ -583,6 +583,7 @@ scratch += sprintf (scratch, "SEEN=%ld", (jiffies - b->seen)/HZ) + 1; event->envp[i] = 0; + printk(MODULE_NAME ": hotplugbutton '%s, %s, %ld'\n", b->pressed?"pressed":"released",b->name, (jiffies - b->seen)/HZ); INIT_WORK(&event->wq, (void *)(void *)hotplug_button, (void *)event); schedule_work(&event->wq); }
The results are (right after the mtd -r <blaat> linux, and not pressing anything):
root@(none):/# dmesg|tail -5 <4>Probing device eth3: No such device <6>b44: eth0: Link is up at 100 Mbps, full duplex. <6>b44: eth0: Flow control is off for TX and off for RX. <4>diag: hotplugbutton 'pressed, reset, 5' <4>diag: hotplugbutton 'released, reset, 0' root@(none):/#
I've tested the reset key with a custom hotplug script, and it works, so it is not a question of a stuck reset key.
(BTW: I just love the way you keep the switch ports isolated, and still broadcast the message "press the reset button key". Nice detail ;-) ).
I will try to look at the changelog which change might cause this. I think #983 is not the culprit, since that only affects the bitstream to the switch, not any I/O ports. (And catting /proc/switch/eth0/registers does not generate a new reset).