Modify

Opened 5 years ago

Last modified 2 years ago

#10714 new defect

Incorrect log output for mount point file systems without a fsck

Reported by: zxdavb Owned by: developers
Priority: low Milestone: Barrier Breaker 14.07
Component: packages Version: 10.03.1
Keywords: fsck block-mount block-hotplug logread Cc: cshore, swalker, nbd

Description

Further to (but separate from) ticket #10697, there is a bug in: trunk/package/block-mount/files/fsck.sh:

logger -t 'fstab' "Unable to check/repair $device; no known fsck for filesystem type $fstype"

which should read:

logger -t 'fstab' "Unable to check/repair $device; no known fsck for filesystem type $fsck_fstype"

As a result, if a mount point has fstab.@mount[n].enabled_fsck=1, and there is no available fsck utility for that filesystem type, then you'll get a log message, which reads:

user.notice fstab: Unable to check/repair /dev/sda1; no known fsck for filesystem type

Instead of what you might see if the above fix was implemented:

user.notice fstab: Unable to check/repair /dev/sda1; no known fsck for filesystem type vfat

Although I think this output would be better:

user.notice fstab: Unable to check/repair /dev/sda1; no known fsck for filesystem type 'vfat'

Again, I am sorry that I am not in a position to post this to the tree myself...

-zxdavb

Attachments (0)

Change History (2)

comment:1 Changed 5 years ago by zxdavb

As a work-around, I have been doing the following (execute it once only):

sed -i '/no known/  s:type \$fstype:type $fsck_fstype:' /lib/functions/fsck.sh

Yes, I know my sed is pants.

-zxdavb

comment:2 Changed 2 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.