Modify

Opened 11 years ago

Closed 11 years ago

#116 closed defect (fixed)

can't build sablevm-classpath due to bad fastjar invocation

Reported by: tristan@… Owned by: nico
Priority: normal Milestone: 1.0-rc5
Component: packages Version: 1.0
Keywords: Cc:

Description

There's a bug in sablevm 1.11.3 that prevents it from building with fastjar. See http://sablevm.org/lists/sablevm-user/2005-July/000351.html. I needed to create a patch, package/sablevm-classpath/patches/100-fastjar.patch in order to get sablevm-classpath to build:

diff -urN sablevm-classpath-1.11.3.orig/lib/Makefile.am sablevm-classpath-1.11.3/lib/Makefile.am
--- sablevm-classpath-1.11.3.orig/lib/Makefile.am       2005-03-24 15:58:58.000000000 -0500
+++ sablevm-classpath-1.11.3/lib/Makefile.am    2005-12-05 23:38:23.208240037 -0500
@@ -93,7 +93,7 @@
 
 libclasspath.jar: classes compile-classes
        if test "x$(FASTJAR)" != "x"; then \
-           $(FASTJAR) $(COMPRESSION_FLAGS) -Mcf libclasspath.jar gnu java javax org > /dev/null; \
+           $(FASTJAR) -Mcf$(COMPRESSION_FLAGS) libclasspath.jar gnu java javax org > /dev/null; \
        elif test "x$(ZIP)" != "x"; then \
            $(ZIP) $(COMPRESSION_FLAGS) -r -D libclasspath.jar gnu java javax org > /dev/null; fi
 
@@ -112,7 +112,7 @@
            cp -f $(top_srcdir)/resource/$$p resources_tmp/$$p; \
        done
        if test x"$(FASTJAR)" != "x"; then cd resources_tmp && \
-           $(FASTJAR) $(COMPRESSION_FLAGS) -Mcf ../resources.jar gnu java javax org > /dev/null; \
+           $(FASTJAR) -Mcf$(COMPRESSION_FLAGS) ../resources.jar gnu java javax org > /dev/null; \
        elif test x"$(ZIP)" != "x"; then cd resources_tmp && \
            $(ZIP) $(COMPRESSION_FLAGS) -r -D ../resources.jar gnu java javax org > /dev/null; fi
        rm -rf resources_tmp
diff -urN sablevm-classpath-1.11.3.orig/lib/Makefile.in sablevm-classpath-1.11.3/lib/Makefile.in
--- sablevm-classpath-1.11.3.orig/lib/Makefile.in       2005-03-24 16:01:29.000000000 -0500
+++ sablevm-classpath-1.11.3/lib/Makefile.in    2005-12-05 23:38:03.514467812 -0500
@@ -501,7 +501,7 @@
 
 libclasspath.jar: classes compile-classes
        if test "x$(FASTJAR)" != "x"; then \
-           $(FASTJAR) $(COMPRESSION_FLAGS) -Mcf libclasspath.jar gnu java javax org > /dev/null; \
+           $(FASTJAR) -Mcf$(COMPRESSION_FLAGS) libclasspath.jar gnu java javax org > /dev/null; \
        elif test "x$(ZIP)" != "x"; then \
            $(ZIP) $(COMPRESSION_FLAGS) -r -D libclasspath.jar gnu java javax org > /dev/null; fi
 
@@ -520,7 +520,7 @@
            cp -f $(top_srcdir)/resource/$$p resources_tmp/$$p; \
        done
        if test x"$(FASTJAR)" != "x"; then cd resources_tmp && \
-           $(FASTJAR) $(COMPRESSION_FLAGS) -Mcf ../resources.jar gnu java javax org > /dev/null; \
+           $(FASTJAR) -Mcf$(COMPRESSION_FLAGS) ../resources.jar gnu java javax org > /dev/null; \
        elif test x"$(ZIP)" != "x"; then cd resources_tmp && \
            $(ZIP) $(COMPRESSION_FLAGS) -r -D ../resources.jar gnu java javax org > /dev/null; fi
        rm -rf resources_tmp

Attachments (0)

Change History (2)

comment:1 Changed 11 years ago by nico

  • Milestone set to 1.0
  • Owner changed from developers to nico
  • Status changed from new to assigned
  • Version set to 1.0

comment:2 Changed 11 years ago by florian

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in r2934, thanks for reporting ans submitting !

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.