Modify

Opened 9 years ago

Closed 9 years ago

#2160 closed defect (fixed)

r8280 broke AR7 leds

Reported by: rootkit85@… Owned by: florian
Priority: normal Milestone: Kamikaze 8.09 RC1
Component: kernel Version:
Keywords: Cc:

Description

Build log:

  CC      drivers/leds/leds-ar7.o
drivers/leds/leds-ar7.c: In function 'ar7_status_led_set':
drivers/leds/leds-ar7.c:40: error: 'AR7_GPIO_BIT_STATUS_LED' undeclared (first use in this function)
drivers/leds/leds-ar7.c:40: error: (Each undeclared identifier is reported only once
drivers/leds/leds-ar7.c:40: error: for each function it appears in.)
drivers/leds/leds-ar7.c: In function 'ar7_leds_probe':
drivers/leds/leds-ar7.c:74: error: 'AR7_GPIO_BIT_STATUS_LED' undeclared (first use in this function)
  CC      arch/mips/pci/pci-dac.o
make[2]: *** [drivers/leds/leds-ar7.o] Error 1
make[1]: *** [drivers/leds] Error 2
make: *** [drivers] Error 2

Attachments (1)

ar7-leds-define.patch (479 bytes) - added by Axel Gembe 9 years ago.
led compile fix

Download all attachments as: .zip

Change History (5)

comment:1 Changed 9 years ago by nico

  • Milestone set to Afterburner 7.09
  • Owner changed from developers to florian

comment:2 Changed 9 years ago by Axel Gembe

Oops, my fault. I removed the define from ar7.h, as it really shouldnt be there (too many different hardware layouts). This should be defined in leds-ar7.c. Ill submit a patch later today.

comment:3 Changed 9 years ago by Axel Gembe

Please try the attached ar7-leds-define.patch patch. It should fix the compilation.

Changed 9 years ago by Axel Gembe

led compile fix

comment:4 Changed 9 years ago by florian

  • Resolution set to fixed
  • Status changed from new to closed

Fixed with [8295], I had disabled the led driver compilation and should have reviewed the patch with more attention.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.