Modify

Opened 9 years ago

Closed 9 years ago

#2672 closed defect (fixed)

bsd build problem for package/

Reported by: rizzo@… Owned by: developers
Priority: normal Milestone:
Component: packages Version:
Keywords: bsd busybox Cc: rizzo@…

Description

FreeBSD has problem building package/busybox of openwrt-trunk.
The problem is the use of find -lname option, which is not available
in BSD find. Rather than adding a dependency on gnu-find for non-linux
platforms, i think it is easier to replace the construct with the pair
-type l -name ... which should be portable across build platforms.

Patch below.
cheers - luigi

> diff -u package/busybox/Makefile.orig.luigi package/busybox/Makefile
--- package/busybox/Makefile.orig.luigi Fri Nov  9 17:43:11 2007
+++ package/busybox/Makefile    Fri Nov  9 17:43:45 2007
@@ -70,7 +70,7 @@
 endef
 
 define Package/busybox/install
-       find $(PKG_BUILD_DIR) -lname "*busybox" -exec rm \{\} \;
+       find $(PKG_BUILD_DIR) -name \*busybox -type l -exec rm \{\} \;
        $(MAKE) -C $(PKG_BUILD_DIR) \
                CC="$(TARGET_CC)" \
                CROSS_COMPILE="$(TARGET_CROSS)" \

Attachments (0)

Change History (2)

comment:1 Changed 9 years ago by nbd

It's certainly more portable, but it's not equivalent.
from the GNU find manpage:

-lname pattern:
File is a symbolic link whose contents match shell pattern pattern.

comment:2 Changed 9 years ago by nbd

  • Resolution set to fixed
  • Status changed from new to closed

GNU find is required. A prereq check has been added in r9710

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.