Modify

Opened 8 years ago

Closed 8 years ago

#2847 closed defect (fixed)

lcd4linux, wrong depends...

Reported by: michu-at-neophobdotcom Owned by: developers
Priority: normal Milestone:
Component: packages Version:
Keywords: Cc:

Description

lcd4linux now depends on libgd:

  make[1] package/utils/lcd4linux-compile
  make[2] -C package/ncurses compile
  make[2] -C feeds/https_svn.openwrt.org_openwrt_packages_/libs/libusb compile
  make[2] -C feeds/https_svn.openwrt.org_openwrt_packages_/libs/libtool compile
  make[2] -C feeds/https_svn.openwrt.org_openwrt_packages_/libs/jpeg compile
  make[2] -C package/zlib compile
  make[2] -C feeds/https_svn.openwrt.org_openwrt_packages_/libs/libpng compile
  make[2] -C feeds/https_svn.openwrt.org_openwrt_packages_/libs/gd compile

I guess this is wrong

Attachments (1)

lcd4linux.patch (1.1 KB) - added by michu-at-neophob-com 8 years ago.
remove lib-gd dep.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by anonymous

Believe me, the libgd dependency is right. Below is the relevant part from objdump output.

objdump -p build_dir/mipsel/lcd4linux-r847/lcd4linux | grep NEEDED:

  NEEDED      libncurses.so.5
  NEEDED      libgd.so.2
  NEEDED      libusb-0.1.so.4
  NEEDED      libm.so.0
  NEEDED      libgcc_s.so.1
  NEEDED      libc.so.0

comment:2 Changed 8 years ago by michu-at-neophob-com

I believe you, but when I compiled lcd4linux with my own Makefile, this wasn't necessary.. lcd4linux will look foor libgd during the configure process, but as far as I know its just used for x11 (which is disabled) and png output..... here is my old makefile:

include $(TOPDIR)/rules.mk

PKG_NAME:=lcd4linux
PKG_REV:=847
PKG_VERSION:=r$(PKG_REV)
PKG_RELEASE:=4

PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2
PKG_SOURCE_URL:=https://ssl.bulix.org/svn/lcd4linux/trunk/
PKG_SOURCE_SUBDIR:=lcd4linux-$(PKG_VERSION)
PKG_SOURCE_VERSION:=$(PKG_REV)
PKG_SOURCE_PROTO:=svn

include $(INCLUDE_DIR)/package.mk

define Package/lcd4linux
  SECTION:=utils
  CATEGORY:=Utilities
  DEPENDS:=+libncurses +libmpd
  TITLE:=LCD display utility
  URL:=http://lcd4linux.bulix.org/
endef

define Package/lcd4linux/description
        LCD4Linux is a small program that grabs information from the kernel and
        some subsystems and displays it on an external liquid crystal display.
        This is a svn snapshot.
        Configured with all plugins and most of the drivers.
        *HINT*: if you want to use GPS functions, make sure that you compiled
        the library nmeap!
endef

define Package/lcd4linux/conffiles
/etc/lcd4linux.conf
endef
                                                                                                                                                      # commas are interpreted by the $(call ...) macro, so define an intermediate variable holding our drivers spec
PKG_CONFIGURE_DRIVERS:=all,!PNG,!RouterBoard,!X11

CONFIGURE_ARGS += \
        --without-x \
        --with-drivers="$(PKG_CONFIGURE_DRIVERS)" \
        --with-plugins=all \

define Build/Configure
        $(call Build/Configure/Default,)
        $(call libtool_disable_rpath)
endef

define Build/Compile
        $(MAKE) -C $(PKG_BUILD_DIR) all
        $(call libtool_fixup_libdir,$(PKG_INSTALL_DIR))
        $(MAKE) -C $(PKG_BUILD_DIR) DESTDIR="$(PKG_INSTALL_DIR)"
endef

define Package/lcd4linux/install
        $(INSTALL_DIR) $(1)/usr/bin
        $(INSTALL_BIN) $(PKG_BUILD_DIR)/$(PKG_NAME) $(1)/usr/bin/
        $(INSTALL_DIR) $(1)/etc
        $(INSTALL_CONF) ./files/$(PKG_NAME).conf $(1)/etc/$(PKG_NAME).conf
        $(INSTALL_DIR) $(1)/etc/init.d
        $(INSTALL_BIN) ./files/$(PKG_NAME).init $(1)/etc/init.d/$(PKG_NAME)
endef

$(eval $(call BuildPackage,lcd4linux))

comment:3 Changed 8 years ago by michu-at-neophob-com

here is the obj-dump of my makefile

  NEEDED      libncurses.so.5
  NEEDED      libusb-0.1.so.4
  NEEDED      libmpd.so.0
  NEEDED      libm.so.0
  NEEDED      libgcc_s.so.1
  NEEDED      libc.so.0

makefile can be found in ticket #2784

Changed 8 years ago by michu-at-neophob-com

remove lib-gd dep.

comment:4 Changed 8 years ago by michu-at-neophob-com

there is still one error, when libgd is available, lcd4linux will use it. I'll open a ticket for it and post it, when updates are available

comment:5 Changed 8 years ago by florian

  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.