Modify

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3550 closed defect (fixed)

Broken init script for ahcpd

Reported by: kerneis@… Owned by: developers
Priority: normal Milestone:
Component: packages Version:
Keywords: ahcpd Cc: jch@…

Description

Hi,

the init script for ahcpd is broken. Here is a patch:

--- ahcpd.init.orig	2008-06-16 11:08:25.000000000 +0200
+++ ahcpd.init	2008-06-16 11:09:04.000000000 +0200
@@ -19,7 +19,7 @@
 	if [ -e $pidfile ] ; then
 		echo "$pidfile exists -- not starting ahcpd." >&2
 	else
-		/usr/bin/ahcpd -D -I $pidfile ${no_ipv4:+-s} ${no_dns:+-N} $authority $interfaces
+		/usr/sbin/ahcpd -D -I $pidfile ${no_ipv4:+-s} ${no_dns:+-N} $authority $interfaces
 	fi
 }

Moreover, I think the following patch should be applied to get more sensible default parameters:

--- ahcpd.config.orig	2008-06-16 11:12:54.000000000 +0200
+++ ahcpd.config	2008-06-16 11:14:54.000000000 +0200
@@ -1,4 +1,4 @@
 config ahcpd
-	option interfaces "wl0 alpha-beta huponomos"
-	option no_dns true
+	option interfaces "wl0"
+	option no_dns false
 	option no_ipv4 true

Indeed, alpha-beta and huponomos are local interfaces used only inside the wifi.pps.jussieu.fr network. The DNS option's change is more a matter of taste but I like to think that the router should be ready, just plug it in power supply and it works (this is the essence of ahcpd/babel). Of course, this supposes that you already have a working ahcpd network.

Last but not least, it could be nice to add a comment underlying the fact that "wl0" might not be the suitable interface (especially in Linksys WRT54GL where it's called wlan0) and thus might have to be changed.

Regards,
Gabriel

Attachments (0)

Change History (6)

comment:1 Changed 8 years ago by florian

  • Resolution set to fixed
  • Status changed from new to closed

Applied in [11505], thanks !

comment:2 Changed 8 years ago by kerneis@…

  • Resolution fixed deleted
  • Status changed from closed to reopened

Ooops! I just realized setting the config variable to "false" does NOT disable it! You have to comment out the line. Sorry about this. ahcpd.init should be fixed I guess, but I don't know how to do this cleanly (and don't want to submit a quick and dirty hack).

Anyway, you should either fix ahcpd.init or indicate the trick of "comment out to disable" in ahcpd.config.

Gabriel

comment:3 Changed 8 years ago by florian

  • Resolution set to wontfix
  • Status changed from reopened to closed

Please submit the proper fix and re-open ticket with the corresponding patch once done.

comment:4 Changed 8 years ago by florian

  • Resolution wontfix deleted
  • Status changed from closed to reopened

Added a note with [11664].

comment:5 Changed 8 years ago by florian

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:6 Changed 8 years ago by jow

Finally cleanly solved with r15266.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.