Modify

Opened 11 years ago

Closed 11 years ago

Last modified 5 years ago

#407 closed enhancement (wontfix)

Port Triggering patch

Reported by: anonymous Owned by: developers
Priority: normal Milestone: 1.0-rc5
Component: kernel Version:
Keywords: Cc:

Description

Patches to add linksys' port triggering functionality to iptables have been sitting on the forums for a number of months. The functionality is very useful for gaming and p2p applications, and it would be great to have this included in OpenWrt.

http://forum.openwrt.org/viewtopic.php?id=1751

Attachments (0)

Change History (11)

comment:1 Changed 11 years ago by florian

  • Resolution set to wontfix
  • Status changed from new to closed

Licence unclear, see "Copyright (C) 2003, CyberTAN Corporation All Rights Reserved."

comment:2 Changed 11 years ago by mbm

  • Milestone set to 1.0-rc5

comment:3 follow-up: Changed 5 years ago by hhash

Concern about the copyright is of paramount importance, but in this case that file
comes from the Linksys GPL linux kernel source and is thus GPL despite what that comment says.

See the "Linksys GPL Code Center" page: http://homesupport.cisco.com/en-us/gplcodecenter

Specifically the WRT54G file: http://homedownloads.cisco.com/downloads/wrt54gs.3.17.4,0.tgz

Once unpacked it's: WRT54GS_3_17_4_0923/release/src/linux/linux/net/ipv4/netfilter/ipt_TRIGGER.c

Modified GPL linux kernel source being redistributed is also GPL code.

These days iptables seems to have the trigger capability built-in so perhaps using that instead of this module would be ever better. This code probably won't even work with the latest linux kernel (no idea, just guessing) so this patch is probably not useful as is anymore, but I wanted to clarify that I think the license is good in case anyone wanted to use it as a starting point.

comment:4 Changed 5 years ago by hhash

Ok, real quick here as I cannot seem to get past the spam filter.

Forums looks to know this was the linksys source, perhaps other concerns.

comment:5 follow-up: Changed 5 years ago by anonymous

I asked, reference number #120409-006579 response in 2-3 business days.

comment:6 in reply to: ↑ 5 Changed 5 years ago by havenster@…

Closed with no explanation. I'll ask again.

comment:7 in reply to: ↑ 3 Changed 5 years ago by jogo

Replying to hhash:

Concern about the copyright is of paramount importance, but in this case that file
comes from the Linksys GPL linux kernel source and is thus GPL despite what that comment says.

Modified GPL linux kernel source being redistributed is also GPL code.

Software licenses do not work this way.

While the GPL requires that all code linked with it is GPL or GPL-compatible, it does not automatically make all code linked with it GPL. So as long as it doesn't say itself that it is GPL or GPL-compatible, it isn't. Which is likely a GPL violation, which would need to be fixed first by CyberTan.

comment:8 Changed 5 years ago by havenster@…

Software licenses do not work this way.

Agreed, mis-stated. Means by redistributing linux like that they (linksys) are likely
violating the GPL. Just trying to clarify that with them.

comment:9 Changed 5 years ago by havenster@…

p.s. This is a monster spam filter you've got here, any tips on getting by it more reliably?

comment:10 Changed 5 years ago by havenster@…

Response saying the first ticket closure was an accident and that they are still working with the ODM to get the license updated.

comment:11 Changed 5 years ago by havenster@…

Heard back from Linksys, they said they fixed it and indeed a new download of the WRT54G src shows this in the comment sections of the ipt_TRIGGER.c file:

  • You can redistribute it and/or modify it under the terms of the GPL v2

So if this src is useful to anyone for implementing Port Triggering in newer linux kernels have at it.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.