Modify

Opened 8 years ago

Closed 8 years ago

#4689 closed defect (fixed)

Kernel oops on ath5k module insertion (intermittent)

Reported by: quentin@… Owned by: developers
Priority: high Milestone:
Component: packages Version:
Keywords: ath5k oops Cc:

Description

I get an oops approx 50% of times when booting the system.

The problem is in the patch package/mac80211/patches/201-ath5k-eeprom.patch, where the patch of function ath5k_eeprom_read_freq_list no longer initialises i to 0, but i is used without further initialisation.

If compiled with V=99, the following gcc warnings are output, but they are reported against the functions in which the inlined instances of ath5k_eeprom_read_freq_list occur, rather than the actual function with the error (and an inspection of the functions against which the error is reported shows that i is initialised):
/u/home/hsn/openwrt/dist/trunk/build_dir/linux-brcm47xx/compat-wireless-2009-02-19/drivers/net/wireless/ath5k/eeprom.c: In function 'ath5k_eeprom_init_11a_pcal_freq':
/u/home/hsn/openwrt/dist/trunk/build_dir/linux-brcm47xx/compat-wireless-2009-02-19/drivers/net/wireless/ath5k/eeprom.c:579: warning: 'i' is used uninitialized in this function
/u/home/hsn/openwrt/dist/trunk/build_dir/linux-brcm47xx/compat-wireless-2009-02-19/drivers/net/wireless/ath5k/eeprom.c: In function 'ath5k_eeprom_read_pcal_info_2413':
/u/home/hsn/openwrt/dist/trunk/build_dir/linux-brcm47xx/compat-wireless-2009-02-19/drivers/net/wireless/ath5k/eeprom.c:1098: warning: 'i' is used uninitialized in this function
/u/home/hsn/openwrt/dist/trunk/build_dir/linux-brcm47xx/compat-wireless-2009-02-19/drivers/net/wireless/ath5k/eeprom.c:1098: warning: 'i' is used uninitialized in this function

The attached patch corrects the patch.

Attachments (1)

201-ath5k-eeprom-patch.patch (447 bytes) - added by quentin@… 8 years ago.
Patch to resolve ath5k oops

Download all attachments as: .zip

Change History (2)

Changed 8 years ago by quentin@…

Patch to resolve ath5k oops

comment:1 Changed 8 years ago by florian

  • Resolution set to fixed
  • Status changed from new to closed

Applied in [14652], thanks a lot !

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.