Modify

Opened 7 years ago

Closed 7 years ago

Last modified 22 months ago

#5200 closed defect (fixed)

/sbin/hotplug-call assumes 2.6 kernel for firmware loads

Reported by: ian@… Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: packages Version: Kamikaze 8.09
Keywords: hotplug hotplug-call Cc:

Description

The first section of /sbin/hotplug-call hijacks the normal /etc/hotplug.d setup and tries to use sysfs to do the firmware load. This is only availble on 2.6 kernels, so it fails to load firmware on a 2.4 kernel.

The "bypass" section looks like a hack. It should at least check the kernel type and existence of a sysfs on /sys (it's not sufficient to just check for /sys).

Commenting out the "bypass" section is enough to get it working on a 2.4 kernel.

Attachments (0)

Change History (4)

comment:1 Changed 7 years ago by ian@…

--- ./package/base-files/files/sbin/hotplug-call 2009-05-23 14:56:36.000000000 -0700
+++ hotplug-call 2009-05-25 16:01:33.000000000 -0700
@@ -5,7 +5,7 @@

# bypass the normal hotplug path for firmware loading
# would otherwise cause problems with drivers like bcm43xx

-[ "firmware" = "$HOTPLUG_TYPE" -a "add" = "$ACTION" ] && {
+(uname -r | grep -q '2\.6') && [ "firmware" = "$HOTPLUG_TYPE" -a "add" = "$ACTION" ] && {

[ -f "/lib/firmware/$FIRMWARE" ] && {

echo 1 > "/sys$DEVPATH/loading"
cp "/lib/firmware/$FIRMWARE" "/sys$DEVPATH/data"

comment:2 Changed 7 years ago by ian@…

--- ./package/base-files/files/sbin/hotplug-call	2009-05-23 14:56:36.000000000 -0700
+++ hotplug-call	2009-05-25 16:01:33.000000000 -0700
@@ -5,7 +5,7 @@
 
 # bypass the normal hotplug path for firmware loading
 # would otherwise cause problems with drivers like bcm43xx
-[ "firmware" = "$HOTPLUG_TYPE" -a "add" = "$ACTION" ] && {
+(uname -r | grep -q '^2\.6') && [ "firmware" = "$HOTPLUG_TYPE" -a "add" = "$ACTION" ] && {
 	[ -f "/lib/firmware/$FIRMWARE" ] && {
 		echo 1 > "/sys$DEVPATH/loading"
 		cp "/lib/firmware/$FIRMWARE" "/sys$DEVPATH/data"

comment:3 Changed 7 years ago by nbd

  • Resolution set to fixed
  • Status changed from new to closed

fixed in r17839

comment:4 Changed 22 months ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.