Modify

Opened 7 years ago

Closed 7 years ago

Last modified 2 years ago

#5220 closed defect (fixed)

[PATCH] Busybox 1.13.4 compile error on insmod.c

Reported by: marcelg-openwrt@… Owned by: nico
Priority: normal Milestone: Barrier Breaker 14.07
Component: base system Version: Trunk
Keywords: busybox, linux 2.4, insmod Cc:

Description

The compile error shown below occurred when
enabling the Busybox option CONFIG_FEATURE_2_4_MODULES to get a working insmod for Linux 2.4 kernels. It was still working under Busybox 1.11.x
(My target: a custom ARM board with a 2.4.37 kernel. 2.6 is not yet supported)

The problem is a missing include when the configation option for 2.4 support is enabled. The attached patch solves this issue.
I will also submit this patch to the busybox maintainers.

  CC      modutils/depmod.o
  CC      modutils/insmod.o
modutils/insmod.c: In function `find_module':
modutils/insmod.c:44: error: storage size of 'myuname' isn't known
modutils/insmod.c:49: warning: implicit declaration of function `uname'
modutils/insmod.c:44: warning: unused variable `myuname'
modutils/insmod.c: At top level:
modutils/insmod.c:21: warning: unused parameter 'statbuf'
modutils/insmod.c:22: warning: unused parameter 'depth'
make[4]: *** [modutils/insmod.o] Error 1
make[3]: *** [modutils] Error 2

Attachments (2)

480-insmod_include_fix_24_modules.patch (419 bytes) - added by marcelg-openwrt@… 7 years ago.
Fixes a compile error for Busybox 1.13.4 insmod with 2.4 kernel support enabled
470-insmod_search.patch (2.9 KB) - added by marcelg-openwrt@… 7 years ago.
A corrected version of the existing 470 patch. Please ignore the new 480 patch.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by marcelg-openwrt@…

Fixes a compile error for Busybox 1.13.4 insmod with 2.4 kernel support enabled

comment:1 Changed 7 years ago by nico

  • Owner changed from developers to nico
  • Status changed from new to assigned

comment:2 Changed 7 years ago by marcelg-openwrt@…

Nico, patch 470-insmod_search.patch introduces this problem. It is not in the official Busybox version, so the best solution is to change the existing 470 patch.

Changed 7 years ago by marcelg-openwrt@…

A corrected version of the existing 470 patch. Please ignore the new 480 patch.

comment:3 Changed 7 years ago by nico

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in [16107], thanks for reporting!

comment:4 Changed 2 years ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.