Modify

Opened 7 years ago

Closed 7 years ago

#7150 closed defect (fixed)

pptpd not packing all binaries

Reported by: Leonardo Rodrigues Magalhaes <leolistas@…> Owned by: developers
Priority: normal Milestone: Backfire 10.03.1
Component: packages Version: Trunk
Keywords: Cc:

Description

pptpd Makefile enabled bcrelay option, with --with-bcrelay. Despite of that, the bcrelay binary is NOT packed, making the bcrelay option unusable.

this has been discussed on the forums on 2007
https://forum.openwrt.org/viewtopic.php?pid=56545
and more recently
https://forum.openwrt.org/viewtopic.php?id=24222

... but probably no ticket was opened to that and it still do not pack bcrelay binary which is compiled fine (tested on recent trunk)

the fix would be simply .... remove the --with-bcrelay option from Makefile, if we dont want that option to be enabled. Or pack the bcrelay file. As simple as:

--- net/pptpd/Makefile
+++ net/pptpd/Makefile
@@ -49,6 +49,7 @@
        $(INSTALL_DIR) $(1)/usr/sbin
        $(CP) $(PKG_INSTALL_DIR)/usr/sbin/pptpd $(1)/usr/sbin/
        $(CP) $(PKG_INSTALL_DIR)/usr/sbin/pptpctrl $(1)/usr/sbin/
+       $(CP) $(PKG_INSTALL_DIR)/usr/sbin/bcrelay $(1)/usr/sbin/
        $(INSTALL_DIR) $(1)/usr/lib/pptpd
        $(CP) $(PKG_INSTALL_DIR)/usr/lib/pptpd/* $(1)/usr/lib/pptpd
        $(INSTALL_DIR) $(1)/etc

Attachments (0)

Change History (1)

comment:1 Changed 7 years ago by nico

  • Milestone changed from Kamikaze to Backfire 10.03.1
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [20877], thanks !

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.