Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7277 closed defect (fixed)

[PATCH] kernel: mini_fo check meta_dentry before use

Reported by: b.sander Owned by: nbd
Priority: normal Milestone: Backfire 10.03.1
Component: packages Version: Trunk
Keywords: Cc:

Description

Hi,

this patch will close ticket #7259 #7238 #7207 (and maybe others). All faults happens with extrootfs.
Check pointer before use:

--- linux-2.6.32/fs/mini_fo/meta.c.bak	2010-03-31 16:46:07.000000000 +0200
+++ linux-2.6.32/fs/mini_fo/meta.c	2010-04-03 01:59:03.000000000 +0200
@@ -48,7 +48,12 @@
 					     dtohd2(dentry),
 					     strlen(META_FILENAME));
 		mutex_unlock(&dtohd2(dentry)->d_inode->i_mutex);
-		if(!meta_dentry->d_inode) {
+
+		if (IS_ERR(meta_dentry)) {
+			return PTR_ERR(meta_dentry);
+		}
+		  
+		if (!meta_dentry->d_inode) {
 			dput(meta_dentry);
 			goto out_ok;
 		}

Regards

Attachments (0)

Change History (4)

comment:1 Changed 7 years ago by pesos <mormo_dark@…>

hi,

Patch don't works for my ticket. I put logs in ticket https://dev.openwrt.org/ticket/7259#comment:9

comment:2 Changed 7 years ago by thepeople

  • Owner changed from developers to nbd
  • Status changed from new to assigned

comment:3 Changed 7 years ago by nbd

  • Resolution set to fixed
  • Status changed from assigned to closed

fixed in r22057

comment:4 Changed 7 years ago by nico

  • Milestone changed from Kamikaze to Backfire 10.03.1

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.