Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7312 closed enhancement (fixed)

[patch] missing uci get functions in lib/config/uci.sh

Reported by: Maddes <maddes_trac@…> Owned by: developers
Priority: normal Milestone: Backfire 10.03.1
Component: base system Version: Trunk
Keywords: Cc:

Description

Several packages read UCI value with /sbin/uci in an ineffective way, e.g. "2>/dev/null" instead of "uci -q".

These first patch adds two new functions to lib/config/uci.sh: uci_get() and uci_get_state()
The counterparts to the existing uci_set() and uci_set_state() functions.

The second patch then changes the scripts that use "/sbin/uci get".

CC: backfire@…

Attachments (3)

uci_get_functions.r21403.patch (1.6 KB) - added by Maddes <maddes_trac@…> 7 years ago.
-p0 patch for trunk/backfire. Adds two new functions to lib/config/uci.sh
uci_get_usage.r21403.patch (2.0 KB) - added by Maddes <maddes_trac@…> 7 years ago.
-p0 patch for trunk/backfire. Change scripts to use new uci_get functions
uci_bump_pkg_release.patch (423 bytes) - added by maddes 7 years ago.
-p0 patch for trunk/backfire. Correct patch to bump uci package release.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by Maddes <maddes_trac@…>

-p0 patch for trunk/backfire. Adds two new functions to lib/config/uci.sh

Changed 7 years ago by Maddes <maddes_trac@…>

-p0 patch for trunk/backfire. Change scripts to use new uci_get functions

comment:1 Changed 7 years ago by Maddes <maddes_trac@…>

This ticket is prerequisite for #7316

comment:2 Changed 7 years ago by jow

  • Resolution set to fixed
  • Status changed from new to closed

Committed in r21489, r21490, r21491, r21492, r21493 and r21494 - thanks!

comment:3 Changed 7 years ago by maddes

Removed bad patch to bump uci package release (r21494 -> #7351 -> r21516).

Attached correct uci package bump patch.

Changed 7 years ago by maddes

-p0 patch for trunk/backfire. Correct patch to bump uci package release.

comment:4 Changed 7 years ago by maddes

Committed in r21529

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.