Modify

Opened 7 years ago

Closed 7 years ago

#7517 closed defect (fixed)

ppp on demand dialing with idle timeout broken since changeset 21280

Reported by: tobias@… Owned by: developers
Priority: normal Milestone: Backfire 10.03.1
Component: packages Version: Trunk
Keywords: ppp Cc:

Description

In LuCi 0.9.0 the option "Automatic disconnect" result in a value 'demand' 'timeoutinseconds' being set for the WAN interface in /etc/config/network.

Since changeset 21280 the demand options is treated as a boolean and the idle timeout value is no longer passed to pppd.
So only if demand is set to 1 we end up in line 128, but then the request fails due to the missing value after "...demand idle".

I changed ppp.sh to fix the problem, please check if this is the correct solution.

Thanks,
Tobias

P.S.: I was compiling the Backfire 10.03 branch r21847 which seems to have that change backmerged.

Attachments (1)

ppp.sh (3.3 KB) - added by anonymous 7 years ago.

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by anonymous

comment:1 Changed 7 years ago by anonymous

diff is better, trac is for patch only. For discussion use the mailinglist

comment:2 Changed 7 years ago by jow

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r21903 - thanks!

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.