dhcptoption splitting entries with space (patch proposal included)
|Reported by:||thomas@…||Owned by:||developers|
|Priority:||normal||Milestone:||Chaos Calmer 15.05|
|Component:||base system||Version:||Backfire 10.03.1 RC2|
Description (last modified by jow)
Using Backupfire 10.03.1.RC3 (could only select RC2 in the webinterface to trac):
When dhcp-options in /etc/config/dhcp contains spaces, e.g.
server\share$ /user:username pw"
dnsmasq fails after /etc/init.d/dnsmasq start (or restart)
I have found, that /etc/init.d/dnsmasq incorrectly splits the option, into -O lan,151,"/CONNECT:
server\share$ -O lan,/user:username -O lan,pw"
I have made a patch, which works for me, but I am unsure, if it has any unwanted siteeffects.
--- dnsmasq.org Thu Aug 19 02:47:13 2010 +++ dnsmasq Thu Aug 19 02:48:06 2010 @@ -299,9 +299,7 @@ local networkid="$2" config_get dhcp_option "$cfg" dhcp_option - for o in $dhcp_option; do - append args "-O $networkid","$o" - done + append args "-O $networkid","$dhcp_option" }