Modify

Opened 6 years ago

Closed 5 years ago

Last modified 22 months ago

#8029 closed defect (fixed)

openswan _realsetup patch broken in rev. 23180

Reported by: didosc@… Owned by: jow
Priority: normal Milestone: Barrier Breaker 14.07
Component: packages Version: Trunk
Keywords: Cc:

Description

In revision 23180 the 110-scripts.patch for openswan package was changed and is now broken.

The patch modifies /usr/lib/ipsec/_realsetup line 286
"rm test -d echo $subsyslock | sed -r 's/(^.*\/)(.*$)/\1/' "&&" touch $subsyslock "&&" rm -f $subsyslock"

And since "rm" doesn't have an option -d it's not going to work.

 rm: invalid option -- d
 BusyBox v1.17.2 (2010-10-03 15:30:41 CEST) multi-call binary.
 
 Usage: rm [OPTIONS] FILE...
 
 Remove (unlink) FILEs
 
 Options:
        -i      Always prompt before removing
        -f      Never prompt
        -R,-r   Recurse

Attachments (0)

Change History (7)

comment:1 Changed 6 years ago by anonymous

Also, while working on that line,

echo $subsyslock | sed -r 's/(^.*\/)(.*$)/\1/'

Could be substituted with

echo ${subsyslock%/*}

which will have the same effect.

More a visual feature than functional, I guess.

comment:2 follow-up: Changed 6 years ago by jow

  • Owner changed from developers to jow
  • Status changed from new to accepted

comment:3 in reply to: ↑ 2 Changed 5 years ago by anonymous

I am no script guru, but I think this is not an unsupported rm option but rather a typo in patch file. The patch should contain "perform test -d ..." instead of "rm test -d ..."

comment:4 Changed 5 years ago by anonymous

why has this not been fixed yet? It looks like it was reported 5 months ago, and I had this problem today. Changed the -d to -rf (from what I could find it does the same thing) and it works like a charm.

comment:5 Changed 5 years ago by jow

  • Resolution set to fixed
  • Status changed from accepted to closed

Because I forgot it. Fixed with r25609.

comment:6 Changed 5 years ago by jow

Typo in patch fixed with follow-up commit r25610.

comment:7 Changed 22 months ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.