Modify

Opened 6 years ago

Closed 5 years ago

#8413 closed defect (fixed)

after gettest update to 0.18. there is an error when build with uClibc 0.9.30.1

Reported by: xiangfu@… Owned by: jow
Priority: highest Milestone: Backfire 10.03.1
Component: packages Version: Backfire 10.03.1 RC4
Keywords: gettext 0.18 localename.c Cc: xiangfu@…

Description

the error message is :
libtool: compile: mipsel-openwrt-linux-uclibc-gcc -c -DLOCALEDIR=\"/usr/share/locale\" -DLOCALE_ALIAS_PATH=\"/usr/share/locale\" -DLIBDIR=\"/usr/lib\" -DBUILDING_LIBINTL -DBUILDING_DLL -DIN_LIBINTL -DENABLE_RELOCATABLE=1 -DIN_LIBRARY -DINSTALLDIR=\"/usr/lib\" -DNO_XMALLOC -Dset_relocation_prefix=libintl_set_relocation_prefix -Drelocate=libintl_relocate -DDEPENDS_ON_LIBICONV=1 -DHAVE_CONFIG_H -I. -I. -I.. -I/home/xiangfu/openwrt-xburst.full_system/staging_dir/target-mipsel_uClibc-0.9.30.1/usr/include -I/home/xiangfu/openwrt-xburst.full_system/staging_dir/target-mipsel_uClibc-0.9.30.1/include -I/home/xiangfu/openwrt-xburst.full_system/staging_dir/toolchain-mipsel_gcc-4.3.3+cs_uClibc-0.9.30.1/usr/include -I/home/xiangfu/openwrt-xburst.full_system/staging_dir/toolchain-mipsel_gcc-4.3.3+cs_uClibc-0.9.30.1/include -Os -pipe -mips32 -mtune=mips32 -funit-at-a-time -fhonour-copts -msoft-float -fpic -fvisibility=hidden ./localename.c -fPIC -DPIC -o .libs/localename.o
./localename.c: In function '_nl_locale_name_thread_unsafe':
./localename.c:2619: error: dereferencing pointer to incomplete type
make[7]: * [localename.lo] Error 1

by search the web. there is one solutions:

http://www.mail-archive.com/bug-gnulib@gnu.org/msg20552.html

(thanks to kyak@#qi-hardware @freenode)

here is the full build log:

http://fidelio.qi-hardware.com/~xiangfu/compile-log/image-full_system-12082010-1400/BUILD_LOG

here is the patch for fixed the compile error:

more 200-fix-localename.c\:2619-error.patch

diff --git a/gettext-runtime/intl/localename.c b/gettext-runtime/intl/localename.c
index 89a9692..5e86bc4 100644
--- a/gettext-runtime/intl/localename.c
+++ b/gettext-runtime/intl/localename.c
@@ -2607,7 +2607,7 @@ gl_locale_name_thread_unsafe (int category, const char *categoryname)

locale_t thread_locale = uselocale (NULL);
if (thread_locale != LC_GLOBAL_LOCALE)

{

-# if GLIBC >= 2
+# if GLIBC >= 2 && !defined UCLIBC

/* Work around an incorrect definition of the _NL_LOCALE_NAME macro in

glibc < 2.12.
See <http://sourceware.org/bugzilla/show_bug.cgi?id=10968>. */

diff --git a/gettext-tools/gnulib-lib/localename.c b/gettext-tools/gnulib-lib/localename.c
index dab5e5b..85149ac 100644
--- a/gettext-tools/gnulib-lib/localename.c
+++ b/gettext-tools/gnulib-lib/localename.c
@@ -2607,7 +2607,7 @@ gl_locale_name_thread_unsafe (int category, const char *categoryname)

locale_t thread_locale = uselocale (NULL);
if (thread_locale != LC_GLOBAL_LOCALE)

{

-# if GLIBC >= 2
+# if GLIBC >= 2 && !defined UCLIBC

/* Work around an incorrect definition of the _NL_LOCALE_NAME macro in

glibc < 2.12.
See <http://sourceware.org/bugzilla/show_bug.cgi?id=10968>. */

now it's compile fine.

Attachments (1)

2619-error.patch (1.3 KB) - added by anonymous 6 years ago.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by anonymous

comment:1 Changed 6 years ago by xiangfu@…

sorry for typo, it's:

after gettext update to 0.18. there is an error when build with uClibc 0.9.30.1

comment:2 Changed 6 years ago by jow

  • Owner changed from developers to jow
  • Status changed from new to accepted

comment:3 Changed 6 years ago by anonymous

Hi!

Is this 2619-error.patch going to be added?

The bug status had been changed to accepted, but the patch is still not there...

comment:4 Changed 5 years ago by anonymous

Hi!

Since the switchable solution for iconv/gettext has been implemented, could you add the patch?

comment:5 Changed 5 years ago by jow

  • Resolution set to fixed
  • Status changed from accepted to closed

Fixed with r25389.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.