Modify

Opened 5 years ago

Closed 5 years ago

Last modified 22 months ago

#9280 closed defect (fixed)

ogg support for mpd

Reported by: benjou Owned by: developers
Priority: normal Milestone: Barrier Breaker 14.07
Component: packages Version: Trunk
Keywords: mpd Cc:

Description

The version of mpd that is in the trunk branch does not seem to support ogg files. Ogg files don't get indexed nor played
The version of mpd is 0.16.1 and it claims that it supports ogg/vorbis, but it does not.

root@OpenWrt:/mnt/disk1/home# mpd -V
mpd (MPD: Music Player Daemon) 0.16.1 

Copyright (C) 2003-2007 Warren Dukes <warren.dukes@gmail.com>
Copyright (C) 2008-2010 Max Kellermann <max@duempel.org>
This is free software; see the source for copying conditions.  There is NO
warranty; not even MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Supported decoders:

[mad] mp3 mp2
[oggflac] ogg oga
[flac] flac
[audiofile] wav au aiff aif
[faad] aac

Supported outputs:

shout null fifo alsa httpd recorder 

More details in the following forum topic: https://forum.openwrt.org/viewtopic.php?pid=133669

Attachments (0)

Change History (5)

comment:1 Changed 5 years ago by benjou

Really no one concerned with this problem?

Is there not even the smallest dirty fix?

:( I miss my ogg music

comment:2 Changed 5 years ago by Tobias Wolf <towolf@…>

It seems that the [oggflac] is the problem. It is not compatible with tremor decoder needed for Vorbis and hence it’s explicitly disabled.

During configuring this is even displayed as disabled -[OggFlac]. But still it somehow gets built in.

comment:3 Changed 5 years ago by Tobias Wolf <towolf@…>

I got it to work by updating MPD to 0.16.5. Somehow they must’ve sorted out the conflict.

Unrelatedly, it might be worth it to slim down MPD. It has too much crap and dependencies enabled that I wouldn’t not use. It might also be worht to split up glib2 since MPD doesn’t need gio or gobject AFAICT; and they are huge too.

For reference, here’s my Makefile (disabled alsa, aac, wav, shout, mms; enabled musepack and oss output)

# mpd -V
mpd (MPD: Music Player Daemon) 0.16.5 

Copyright (C) 2003-2007 Warren Dukes <warren.dukes@gmail.com>
Copyright (C) 2008-2010 Max Kellermann <max@duempel.org>
This is free software; see the source for copying conditions.  There is NO
warranty; not even MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Supported decoders:

[mad] mp3 mp2
[vorbis] ogg oga
[oggflac] ogg oga
[flac] flac
[mpcdec] mpc

Supported outputs:

null oss httpd 

Supported encoders:

null flac 

Supported protocols:

file:// http:// 
--- /tmp/Makefile	2011-10-18 17:48:37.986020024 +0200
+++ feeds/packages/sound/mpd/Makefile	2011-10-18 20:15:15.054432749 +0200
@@ -8,12 +8,12 @@
 include $(TOPDIR)/rules.mk
 
 PKG_NAME:=mpd
-PKG_VERSION:=0.16.1
+PKG_VERSION:=0.16.5
 PKG_RELEASE:=1
 
 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2
 PKG_SOURCE_URL:=@SF/musicpd
-PKG_MD5SUM:=4d07459125ab0154c5b4fe364331498a
+PKG_MD5SUM:=f7564cff12035f6a1112cce770655df7
 
 PKG_INSTALL:=1
 PKG_BUILD_PARALLEL:=1
@@ -26,13 +26,10 @@
   CATEGORY:=Sound
   TITLE:=Music Player Daemon
   URL:=http://www.musicpd.org/
-# libvorbis and therewith libogg are needed for shout support
   DEPENDS:= \
-	+AUDIO_SUPPORT:alsa-lib \
-	+libaudiofile \
-	+BUILD_PATENTED:libfaad2 +BUILD_PATENTED:libmad \
-	+glib2 +libcurl +libflac +libmms +libpthread +libshout \
-	+libvorbis +libvorbisidec +libid3tag
+	+BUILD_PATENTED:libmad \
+	+glib2 +libcurl +libflac +libpthread +libid3tag +libmpcdec \
+	+libvorbisidec
 endef
 
 define Package/mpd/description
@@ -42,24 +39,22 @@
 endef
 
 define Package/mpd/conffiles
-/etc/avahi/services/mpd.service
 /etc/mpd.conf
 endef
 
-# oggflac is not compatible with tremor
 CONFIGURE_ARGS += \
 	$(call autoconf_bool,CONFIG_BUILD_PATENTED,mad) \
-	$(call autoconf_bool,CONFIG_AUDIO_SUPPORT,alsa) \
-	--enable-audiofile \
-	--disable-mpc \
-	$(call autoconf_bool,CONFIG_BUILD_PATENTED,aac) \
+	--disable-alsa \
+	--disable-audiofile \
+	--enable-mpc \
+	--disable-aac \
 	--disable-lsr \
 	--disable-ao \
 	--disable-mvp \
 	--disable-lame-encoder \
 	--disable-ffmpeg \
 	--enable-flac \
-	--enable-vorbis \
+	--disable-vorbis \
 	--disable-oggflac \
 	--disable-cue \
 	--disable-jack \
@@ -67,19 +62,23 @@
 	--disable-pulse \
 	--disable-sidplay \
 	--disable-sqlite \
-	--enable-shout \
+	--disable-shout \
 	--enable-id3 \
-	--enable-lastfm \
-	--enable-mms \
+	--disable-lastfm \
+	--disable-mms \
 	--enable-curl \
-	--disable-oss \
+	--enable-oss \
 	--with-zeroconf=no \
 	--disable-test \
 	--with-tremor=yes \
-	--with-faad="$(STAGING_DIR)/usr" \
+	--disable-fifo \
+	--disable-recorder-output \
+	--disable-vorbis-encoder \
+	--disable-wave-encoder \
 
 CONFIGURE_VARS += \
 	FLAC_CFLAGS="$(TARGET_CFLAGS) -I$(STAGING_DIR)/usr/include/FLAC" \
+	mpcdec_prefix="$(STAGING_DIR)/usr" \
 	FLAC_LIBS="$(TARGET_LDFLAGS) -lFLAC" \
 	$(if $(CONFIG_BUILD_PATENTED),MAD_CFLAGS="$(TARGET_CFLAGS)") \
 	$(if $(CONFIG_BUILD_PATENTED),MAD_LIBS="$(TARGET_LDFLAGS) -lmad") \
@@ -97,8 +96,6 @@
 	$(INSTALL_BIN) $(PKG_INSTALL_DIR)/usr/bin/mpd $(1)/usr/bin/
 	$(INSTALL_DIR) $(1)/etc/init.d
 	$(INSTALL_BIN) ./files/mpd.init $(1)/etc/init.d/mpd
-	$(INSTALL_DIR) $(1)/etc/avahi/services
-	$(INSTALL_DATA) ./files/mpd.service $(1)/etc/avahi/services/
 endef
 
 $(eval $(call BuildPackage,mpd))

comment:4 Changed 5 years ago by nico

  • Resolution set to fixed
  • Status changed from new to closed

Done, mpd was updated to 0.16.5 and split in 2 variants -full & -mini in [28524]

comment:5 Changed 22 months ago by jow

  • Milestone changed from Attitude Adjustment 12.09 to Barrier Breaker 14.07

Milestone Attitude Adjustment 12.09 deleted

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.